Projekt

Allgemein

Profil

« Zurück | Weiter » 

Revision d2e07831

Von Jan Büren vor etwa 5 Jahren hinzugefügt

  • ID d2e078315810c382a8f8d331849fceedbcc7dda7
  • Vorgänger e83fcf3a
  • Nachfolger 5172a3be

BankTransaction: weniger im Controller rechnen -> ausgelagert in Objekt

s.a. Commit davor. Redundanzen hier direkt vorbeugen.

Unterschiede anzeigen:

SL/Controller/BankTransaction.pm
563 563
  my $worker = sub {
564 564
    my $bt_id                 = $data{bank_transaction_id};
565 565
    my $sign                  = $bank_transaction->amount < 0 ? -1 : 1;
566
    my $amount_of_transaction = $sign * $bank_transaction->amount;
567
    my $assigned_amount       = $sign * $bank_transaction->invoice_amount;
568
    my $not_assigned_amount   = $amount_of_transaction - $assigned_amount;
566
    my $not_assigned_amount   = $bank_transaction->not_assigned_amount;
569 567
    my $payment_received      = $bank_transaction->amount > 0;
570 568
    my $payment_sent          = $bank_transaction->amount < 0;
571 569

  
......
614 612
      $n_invoices++ ;
615 613

  
616 614

  
617
      if (!$amount_of_transaction && $invoice->open_amount) {
615
      if (!$not_assigned_amount && $invoice->open_amount) {
618 616
        return {
619 617
          %data,
620 618
          result  => 'error',

Auch abrufbar als: Unified diff