Projekt

Allgemein

Profil

« Zurück | Weiter » 

Revision ac05693f

Von Tamino Steinert vor etwa 2 Jahren hinzugefügt

  • ID ac05693fdbaf88eae7ff1c959d785066b4235031
  • Vorgänger 4f78e190
  • Nachfolger 5e8868e4

TypeData: nutzte Konstanten anstatt String für Typen

Unterschiede anzeigen:

SL/DB/DeliveryOrder.pm
use SL::DB::Unit;
use SL::DB::DeliveryOrder::TypeData qw(:types);
use SL::DB::Reclamation::TypeData qw(:types);
use SL::Helper::Number qw(_format_total _round_total);
......
],
);
return first { $_->is_type('sales_order') } @{ $orders };
return first { $_->is_type(SALES_ORDER_TYPE()) } @{ $orders };
}
sub type {
......
sub displayable_type {
my $type = shift->type;
return $::locale->text('Sales Delivery Order') if $type eq 'sales_delivery_order';
return $::locale->text('Purchase Delivery Order') if $type eq 'purchase_delivery_order';
return $::locale->text('Sales Delivery Order') if $type eq SALES_DELIVERY_ORDER_TYPE();
return $::locale->text('Purchase Delivery Order') if $type eq PURCHASE_DELIVERY_ORDER_TYPE();
die 'invalid type';
}
......
sub convert_to_reclamation {
my ($self, %params) = @_;
$params{destination_type} = $self->is_sales ? 'sales_reclamation'
: 'purchase_reclamation';
$params{destination_type} = $self->is_sales ? SALES_RECLAMATION_TYPE()
: PURCHASE_RECLAMATION_TYPE();
my $reclamation = SL::DB::Reclamation->new_from($self, %params);
......
}
# infer type from legacy fields if not given
$record_args{order_type} //= $source->customer_id ? 'sales_delivery_order'
: $source->vendor_id ? 'purchase_delivery_order'
: $source->is_sales ? 'sales_delivery_order'
$record_args{order_type} //= $source->customer_id ? SALES_DELIVERY_ORDER_TYPE()
: $source->vendor_id ? PURCHASE_DELIVERY_ORDER_TYPE()
: $source->is_sales ? SALES_DELIVERY_ORDER_TYPE()
: croak "need some way to set delivery order type from source";
my $delivery_order = $class->new(%record_args);
$delivery_order->assign_attributes(%{ $params{attributes} }) if $params{attributes};
my $items = delete($params{items}) || $source->items_sorted;
my @items = ( $delivery_order->is_type(SUPPLIER_DELIVERY_ORDER_TYPE) && ref($source) ne 'SL::DB::Reclamation' ) ?
my @items = ( $delivery_order->is_type(SUPPLIER_DELIVERY_ORDER_TYPE()) && ref($source) ne 'SL::DB::Reclamation' ) ?
()
: map { SL::DB::DeliveryOrderItem->new_from($_, %params) } @{ $items };

Auch abrufbar als: Unified diff